IndexDefinition class is derived from TSqlStatement however it is not a statement
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
Research direction
Start by tracing the inheritance of IndexDefinition, TSqlStatement, IndexStatement, and DropIndexStatement in the ScriptDOM source. Determine how inline index definitions are represented within CREATE TABLE and DECLARE TABLE, then assess the hierarchy change needed so only standalone statements derive from TSqlStatement; done means consumers can distinguish statements without special-casing IndexDefinition.
Written by the indexing model from the issue text.
Description
Inline indices are represented in ScriptDom as instances of IndexDefinition class. These index definitions in T-SQL can only be a part of CREATE TABLE/DECLARE TABLE statement and cannot be used as separate statements.
There is also IndexStatement class which represents CREATE/ALTER/DROP INDEX statements (well, drop has a separate implementation) which are true standalone statements.
While developing code analysis, code formatting, coverage computation tools one cannot be sure that descendant of TSqlStatement class is actually a statement and has to manually exclude/ignore instances of "false-statement" classes such as IndexDefinition.
It'd be great if such expressions which cannot exist separately from a surrounding statement were not derived from TSqlStatement class.
- Dominant language
- GAP
- Stars
- 277
- Forks
- 43
- Avg merge
- 6d 17h
- Merged PRs (30d)
- 3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/SqlScriptDOM
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
microsoft/SqlScriptDOM#228 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
microsoft/SqlScriptDOM#183 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 56/100
microsoft/SqlScriptDOM#226 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
microsoft/SqlScriptDOM#225 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
microsoft/SqlScriptDOM#224 ·
All issues in microsoft/SqlScriptDOM
Similar issues
-
todo:perf
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
objectionary/eo#8894 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
objectionary/phie#154 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
objectionary/jeo-maven-plugin#1774 ·
-
Minor breakage w/ LLVM 7: `test_llvm.cpp: error: cannot convert 'llvm::Module' to 'llvm::Module*'` Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100