`dond` error in finally block
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
Research direction
Start in qcodes/dataset/dond/do_nd.py at the finally block around line 738, and trace how datasavers is assigned inside the try block. Reproduce an exception before that assignment and confirm the fix prevents UnboundLocalError while preserving the intended finally-block cleanup behavior.
Written by the indexing model from the issue text.
Description
finally block in dond (here) relies on a parameter from try block.
This results in an UnboundLocalError when the exception happens before datasavers is assigned.
try:
with _catch_interrupts() as interrupted, ExitStack() as stack, params_meas_caller as call_params_meas:
datasavers = [
stack.enter_context(group.measurement_cxt.run())
for group in measurements.groups
]
...
finally:
for datasaver in datasavers:
...
- Dominant language
- Python
- Stars
- 459
- Forks
- 361
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 79
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/Qcodes
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
microsoft/Qcodes#8168 · 3 comments ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
microsoft/Qcodes#1087 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
All instruments share a single logging.Logger, so per-instrument log configuration leaks between instrumentsPossibly taken @ymampaey claimed this 13 days ago. Open
Difficulty 5/5 Over a week Newbie friendliness 48/100
Maintainers usually reply within 1 day
-
Export to xarray dataset fails when two data variables do not share same setpointsMay be free again @jenshnielsen claimed this 102 days ago, and no pull request is open. Open
microsoft/Qcodes#8232 · 1 reaction · 2 assignees ·
Maintainers usually reply within 1 day
All issues in microsoft/Qcodes
Similar issues
-
namespace operations
Difficulty 1/5 Under an hour Newbie friendliness 72/100
EclipseFdn/open-vsx.org#13737 ·
Maintainers usually reply within 1 day
-
Zero-token evaluations are treated as missing cost in selectionPossibly taken @sylvesterkaczmarek claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
google-research/rrsi#6 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
aws-samples/sample-aws-genai-db-modernizer#294 ·
Maintainers usually reply within 1 day
-
feedback simulation workshop
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
githubnext/gh-aw-workshop#4174 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
WingedGuardian/GENesis-AGI#2852 ·
Maintainers usually reply within 1 day