Issues with including "sal.h"

Open
#346 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
58/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
build-system

Research direction

Start by tracing how SHMath downloads and exposes sal.h during the build, then inspect the include handling used when sal.h already exists. Confirm the intended destination and compilation include behavior, and verify that both a fresh download and an existing-file build include the sal directory correctly.

Written by the indexing model from the issue text.

Description

Hi.
With SHMath, there are two issues.

  1. When it downloads "sal.h", it downloads to the build folder. I don't think this is intended, it should likely be in "Inc" folder or elsewhere.
  2. If that file is already there, then "sal" directory won't be included for compilation.
Dominant language
C++
Stars
1.8k
Forks
262
Avg merge
3d 12h
Merged PRs (30d)
5

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/DirectXMath

All issues in microsoft/DirectXMath

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.