Issues with check-parse-results
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- typescript
Research direction
Start with packages/dtslint-runner/src/check-parse-results.ts, especially the checks at lines 34–36, to understand the current throwing and logging behavior. Identify how these checks could run overnight and where their output would be visible. Done means overnight execution is covered, all failures are logged instead of stopping at the first, and the results appear somewhere visible.
Written by the indexing model from the issue text.
Description
So, we just merged https://github.com/microsoft/DefinitelyTyped-tools/pull/484, and there are some issues with it:
- The checks made by check-parse-results should ideally also run overnight to make sure everything is in order on DT, not only when there are PRs to this tools repo.
- check-parse-results seems to write from the logger, but the checks it performs don't write to the log, they throw instead (https://github.com/microsoft/DefinitelyTyped-tools/blob/master/packages/dtslint-runner/src/check-parse-results.ts#L34-L36). We should change the checks so they log instead of throwing. This would mean that we log all failures at once (instead of stopping on the first failure).
- The result of logging should show up somewhere visible. That's related to the first item above.
cc @jablko
- Dominant language
- TypeScript
- Stars
- 423
- Forks
- 237
- Avg merge
- 18h 18m
- Merged PRs (30d)
- 11
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/DefinitelyTyped-tools
-
Difficulty 3/5 1-2 days Newbie friendliness 66/100
microsoft/DefinitelyTyped-tools#1324 · 8 comments ·
Maintainers usually reply within 3 days
-
Difficulty 4/5 3-5 days Newbie friendliness 32/100
microsoft/DefinitelyTyped-tools#1230 · 1 comment ·
Maintainers usually reply within 3 days
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
microsoft/DefinitelyTyped-tools#1229 ·
Maintainers usually reply within 3 days
-
microsoft/DefinitelyTyped-tools#1218 · 1 reaction · 1 assignee ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
microsoft/DefinitelyTyped-tools#1211 · 1 comment ·
Maintainers usually reply within 3 days
All issues in microsoft/DefinitelyTyped-tools
Similar issues
-
check:passed streams:add
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Fission-AI/OpenSpec#1986 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nestjs/docs.nestjs.com#3554 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
publicodes/publicodes#868 ·
-
namespace operations
Difficulty 1/5 Under an hour Newbie friendliness 78/100
EclipseFdn/open-vsx.org#13488 ·
Maintainers usually reply within 2 days