dts-critic incorrectly assumes export default of re-export
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- devtools
Research direction
Start by locating getDtsExportType and tracing how it handles the mongoose-mock declaration and the re-exported mongoose alias. Reproduce the dts-critic result with the TypeScript snippet in the issue; done means mongoose-mock is no longer reported as having an export default solely because mongoose has one.
Written by the indexing model from the issue text.
Description
In mongoose-mock:
import mongoose = require('mongoose');
declare var mock: mongoose.Mongoose;
export = mock;
dts-critic incorrectly says that mongoose-mock has an export default because mongoose has an export default. getDtsExportType should either not follow aliases or should be aware of them.
- Dominant language
- TypeScript
- Stars
- 423
- Forks
- 237
- Avg merge
- 18h 18m
- Merged PRs (30d)
- 11
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/DefinitelyTyped-tools
-
Difficulty 3/5 1-2 days Newbie friendliness 66/100
microsoft/DefinitelyTyped-tools#1324 · 7 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 32/100
microsoft/DefinitelyTyped-tools#1230 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
microsoft/DefinitelyTyped-tools#1229 ·
-
microsoft/DefinitelyTyped-tools#1218 · 1 reaction · 1 assignee ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
microsoft/DefinitelyTyped-tools#1211 · 1 comment ·
All issues in microsoft/DefinitelyTyped-tools
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
security
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
IBM/node-sdk-core#373 ·
-
e2e-failure ready-to-code
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
chore
Difficulty 2/5 1-3 hours Newbie friendliness 88/100