convert NamedTuples to @dataclass
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start by reading model.py and inventory every NamedTuple and @dataclass usage, noting how the frontend wrapper consumes these models. Check whether converting the remaining NamedTuples preserves the existing behavior, and consider the work done when model.py uses a consistent representation without breaking the wrapper.
Written by the indexing model from the issue text.
Description
Hi, I'm creating a frontend wrapper for this project and noticed that NamedTuple and @dataclasses are used almost interchangeably in model.py. I was wondering why that's the case and if it would be possible to just change all NamedTuples to @dataclasses. This would make the model more consistent. I tried changing it for a couple classes and didn't notice anything breaking.
- Dominant language
- Jupyter Notebook
- Stars
- 1.8k
- Forks
- 283
- PR merge metrics
- No merged PRs in 30d
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/CyberBattleSim
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
microsoft/CyberBattleSim#156 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
microsoft/CyberBattleSim#152 ·
-
question
Difficulty 5/5 Over a week Newbie friendliness 25/100
microsoft/CyberBattleSim#117 · 1 comment ·
-
DQL still learning at evaluation timeMay be free again A pull request for this issue was closed without being merged. Openbug
Difficulty 4/5 3-5 days Newbie friendliness 38/100
microsoft/CyberBattleSim#115 · 1 comment ·
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 20/100
microsoft/CyberBattleSim#96 · 3 comments ·
All issues in microsoft/CyberBattleSim
Similar issues
-
Bug Enhancement Performance
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
flashinfer-ai/flashinfer#6212 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
zenstackhq/zenstack#2873 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
activescott/lessmsi#306 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Jason-Vaughan/TangleClaw#2195 ·
Maintainers usually reply within 1 day