FR: Allow for EACCES when enforceSourceReadsUnderPackageRoots is used
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 28/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- csharp, javascript
- Domain
- operating-systems, tooling
Research direction
Start by locating the enforceSourceReadsUnderPackageRoots entry point and the existing handling for EACCES in BuildXL. Review how filesystem reads are currently denied and how sandbox failures are reported. Done means eligible parent-directory reads produce EACCES so traversal-based tools can stop without failing the build, with tests covering the behavior.
Written by the indexing model from the issue text.
Description
A common pattern is to have tools walk up the directory hierarchy and collapse parent configurations. Example packages which do this: eslint, cosmiconfig. However, when enforceSourceReadsUnderPackageRoots is used in BuildXL, this is a bit annoying - it requires that the developer find each package's method to stop traversals (eg, root: true in eslint's config).
These tools generally[^1] handle EACCES errors well, and use that as a signal to stop traversals. Could BuildXL add support for preventing read access, rather than failing the build?
This is related to an open feature request in the esbuild project: https://github.com/evanw/esbuild/issues/4036 - this tool doesn't provide any way to stop the directory traversal, and instead relies on EACCES errors being thrown.
[^1]: I have not conducted a thorough audit of the ecosystem; this is just based on my experience and a light skimming of the source code of several packages.
- Dominant language
- C#
- Stars
- 1k
- Forks
- 167
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/BuildXL
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 30/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
All issues in microsoft/BuildXL
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Esri/calcite-dotnet-toolkit#30 · 1 reaction ·
-
VideoViewer: rotated (portrait phone) videos shown sideways when system decimal separator is a commaOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
security
Difficulty 1/5 Under an hour Newbie friendliness 85/100
MorganHacks/Arctic#182 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Volodymyr-Petrunin/Bankomaten#45 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
thekid/inotify-win#45 ·