fix(ci): read only GitHub Actions' ci-status runs in the release rebuild decision
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #9653 by @kyle-sexton — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Read .github/workflows/release-publish-plugins.yml around line 116 and .github/scripts/release-publish-plugins/decide-rebuild.sh to locate both check-run reads; compare them with .github/scripts/pr-merge/gate-check.mjs around line 56. Add coverage showing a later successful ci-status from another app does not decide the release rebuild, and keep ties or unreadable start times failing closed.
Written by the indexing model from the issue text.
Description
Refs: #9610
Problem
.github/workflows/release-publish-plugins.yml:116 and .github/scripts/release-publish-plugins/decide-rebuild.sh read ci-status check runs without an app_id filter and pick the newest by started_at. Another GitHub App can post a check run named ci-status with a later start time and win that pick. The ruleset (ci-status required from the GitHub Actions app) and the merge queue still protect merging, but the release path decides on its own read.
Fix
Add app_id=15368 to those reads, as .github/scripts/pr-merge/gate-check.mjs:56 and pr-merge's Dependabot gate do, and keep ties and unreadable start times failing closed.
Acceptance criteria
- Both reads filter on the GitHub Actions app id
- A test shows another app's later
ci-statussuccess does not decide
- Dominant language
- Shell
- Stars
- 22
- Forks
- 2
- Avg merge
- 3h 42m
- Merged PRs (30d)
- 938
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from melodic-software/claude-code-plugins
-
admission-deferred priority: medium status: ready work-class: scoped
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
melodic-software/claude-code-plugins#9914 · 1 comment ·
Maintainers usually reply within 1 day
-
priority: low status: ready work-class: mechanical
Difficulty 1/5 Under an hour Newbie friendliness 88/100
melodic-software/claude-code-plugins#9911 · 2 comments ·
Maintainers usually reply within 1 day
-
priority: medium status: ready work-class: scoped
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
melodic-software/claude-code-plugins#9901 · 2 comments ·
Maintainers usually reply within 1 day
-
admission-deferred needs-human needs-triage status: needs-decision
Difficulty 2/5 1-2 days Newbie friendliness 78/100
melodic-software/claude-code-plugins#9865 · 1 comment ·
Maintainers usually reply within 1 day
-
priority: medium status: needs-decision work-class: scoped
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
melodic-software/claude-code-plugins#9855 · 2 comments ·
Maintainers usually reply within 1 day
All issues in melodic-software/claude-code-plugins
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
YunoHost-Apps/plakar_ynh#34 ·
-
[Bug] 容器无法优雅关闭Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
NapNeko/NapCat-Docker#140 · 1 comment ·
-
Screensaver picked up transparency setting from GhosttyPossibly taken A pull request linked to this issue is open or already merged. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Link Checker ReportOpenautomated issue report
Difficulty 1/5 Under an hour Newbie friendliness 85/100
a2aproject/A2A#2387 ·
Maintainers usually reply within 4 days
-
bug mac-app
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day