fix(pr-pipeline): apply-verdict readFields reads a malformed field-values answer as no fields set
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 83/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
Research direction
Read .github/scripts/intake-triage/apply-verdict.mjs around readFields and the related apply-verdict.test.mjs cases. Run the intake-triage suite first, then add coverage for a non-array field-values answer and verify it fails without writing fields, labels, or comments. Done when readFields rejects malformed answers, an empty array remains valid, and the suite passes.
Written by the indexing model from the issue text.
Description
Problem
.github/scripts/intake-triage/apply-verdict.mjs readFields (line 279 on main) reads the issue-field-values answer with Array.isArray(rows) ? rows : []. A non-array answer (an error body, a changed shape) reads as "no fields set", so every person-set Size, Complexity and Uncertainty looks unset and intake's verdict can overwrite it.
#9566 fixed the same pattern in label-unblocked.mjs (issueVerdict) and in resolve-config.mjs fieldSetters, which now throw on an unexpected shape so the run writes nothing.
Acceptance criteria
-
readFieldsthrows when the issue-field-values answer is not an array; an empty array is still a valid answer. - A test in
apply-verdict.test.mjsshows a non-array field-values answer writes no field, label or comment, and fails on the current code. - The PR's CI runs the intake-triage suite and it passes.
Context
Found by the fix pass on #9566 (review finding I2's sibling). Size: Small. Complexity: Low. Uncertainty: Known.
- Dominant language
- Shell
- Stars
- 22
- Forks
- 2
- Avg merge
- 2h 45m
- Merged PRs (30d)
- 940
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from melodic-software/claude-code-plugins
-
admission-deferred priority: medium status: ready work-class: scoped
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
melodic-software/claude-code-plugins#10128 · 1 comment ·
Maintainers usually reply within 1 day
-
pr-pipeline: clear a feedback-not-landed escalation once the head moves and no lane thread is openOpenpriority: medium status: needs-decision work-class: scoped
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
melodic-software/claude-code-plugins#10074 · 4 comments ·
Maintainers usually reply within 1 day
-
agent-ready priority: medium status: ready work-class: scoped
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
melodic-software/claude-code-plugins#9914 · 1 comment ·
Maintainers usually reply within 1 day
-
fix(harness-ops): bound the OTEL hot tier's total size, not only each filePossibly taken @melodic-automation-lanes claimed this today. Openagent-ready priority: medium status: ready work-class: scoped
Difficulty 2/5 1-2 days Newbie friendliness 78/100
melodic-software/claude-code-plugins#9865 · 3 comments ·
Maintainers usually reply within 1 day
-
priority: medium status: needs-decision work-class: scoped
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
melodic-software/claude-code-plugins#9855 · 5 comments ·
Maintainers usually reply within 1 day
All issues in melodic-software/claude-code-plugins
Similar issues
-
TLS guide repeats certs/ in the certificate directoryPossibly taken @maheshrijal claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
prometheus/docs#3156 ·
Maintainers usually reply within 2 days
-
triaged
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
fullsend-ai/agents#1786 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
osam-cologne/archlinux-proaudio#917 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
security
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
IBM/bob-oic-tutorials#24 ·
Maintainers usually reply within 1 day