fix(pr-pipeline): mark check-signed-commits' needs-human comment so lane fixers hold on it
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- github, javascript, shell
Research direction
Start by reading gate-source.mjs and its prHold logic, then inspect check-signed-commits and clear-escalations.mjs to trace how the comment and label are handled. Add a marker to the check's comment, count marked comments as holds in both paths, and add tests for a marked comment holding and an unmarked bot comment not holding.
Written by the indexing model from the issue text.
Description
Problem
The lane fixers (fix-ci, fix-docs, resolve-conflicts, address-feedback) and clear-escalations.mjs treat a bot comment posted after the needs-human label as no hold, because only a person's comment or review holds (#9561, gate-source.mjs prHold). check-signed-commits adds an unmarked needs-human on top of a lane escalation, so the fixers keep running on a pull request that check flagged, and clear-escalations can lift the label.
Exploiting it needs write access to push unsigned commits, so this is low severity (P3 in #9561's security review).
Fix
Give check-signed-commits's comment a marker, and count that marker as a hold in prHold and in clear-escalations. Add tests for the marked comment holding and for an unmarked bot comment not holding.
Refs: #9561
- Dominant language
- Shell
- Stars
- 22
- Forks
- 2
- Avg merge
- 2h 45m
- Merged PRs (30d)
- 940
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from melodic-software/claude-code-plugins
-
admission-deferred priority: medium status: ready work-class: scoped
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
melodic-software/claude-code-plugins#10128 · 1 comment ·
Maintainers usually reply within 1 day
-
pr-pipeline: clear a feedback-not-landed escalation once the head moves and no lane thread is openOpenpriority: medium status: needs-decision work-class: scoped
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
melodic-software/claude-code-plugins#10074 · 4 comments ·
Maintainers usually reply within 1 day
-
agent-ready priority: medium status: ready work-class: scoped
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
melodic-software/claude-code-plugins#9914 · 1 comment ·
Maintainers usually reply within 1 day
-
fix(harness-ops): bound the OTEL hot tier's total size, not only each filePossibly taken @melodic-automation-lanes claimed this 1 day ago. Openagent-ready priority: medium status: ready work-class: scoped
Difficulty 2/5 1-2 days Newbie friendliness 78/100
melodic-software/claude-code-plugins#9865 · 3 comments ·
Maintainers usually reply within 1 day
-
priority: medium status: needs-decision work-class: scoped
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
melodic-software/claude-code-plugins#9855 · 5 comments ·
Maintainers usually reply within 1 day
All issues in melodic-software/claude-code-plugins
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
glossyio/traffic-monitor#256 ·
Maintainers usually reply within 1 day
-
source:reader type:content-error
Difficulty 1/5 1-3 hours Newbie friendliness 84/100
stephrobert/blog-roadmap#121 ·
-
lesson-submission pending-review
Difficulty 1/5 Under an hour Newbie friendliness 74/100
Ikalus1988/MisakaNet#3899 ·
Maintainers usually reply within 1 day
-
sync with NCO's changes
Difficulty 1/5 Under an hour Newbie friendliness 82/100