fix(knowledge): list-promotion-candidates prints a stack trace on a malformed claim inventory
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, nodejs
- Domain
- cli
Research direction
Start with list-promotion-candidates.js in plugins/knowledge/skills/video-digest/extraction/watch/: the zero-sessions throw is around lines 45-48 and the CLI block around lines 114-121 has no catch. Copy the error handling from the sibling vision-gated-promote.js (lines 93-107), which writes the message to stderr and exits 1. Done means a malformed inventory prints only the one-line message with the format hint and exits nonzero, with a CLI test that checks both.
Written by the indexing model from the issue text.
Description
Summary
Run as a CLI, list-promotion-candidates.js calls listPromotionCandidates with no error handling, so its documented failure (no session parsed from research/claim-inventory.md) and any missing-file error escape as an uncaught exception with a Node stack trace. The sibling vision-gated-promote.js catches, prints the message to stderr and exits 1.
Failure scenario
Expected: a malformed claim inventory prints the one-line message with the format hint to stderr and exits with a nonzero code, with no stack trace.
Actual: the function throws at the zero-sessions check, and the CLI block does not catch it, so Node prints the stack trace. The useful part (SESSION_FORMAT_HINT) is buried under it.
Evidence
- The throw: https://github.com/melodic-software/claude-code-plugins/blob/7787be41e98e30cd6e3b82e99494886d77e30895/plugins/knowledge/skills/video-digest/extraction/watch/list-promotion-candidates.js#L45-L48
- CLI block with no catch: https://github.com/melodic-software/claude-code-plugins/blob/7787be41e98e30cd6e3b82e99494886d77e30895/plugins/knowledge/skills/video-digest/extraction/watch/list-promotion-candidates.js#L114-L121
- The sibling's pattern to match: https://github.com/melodic-software/claude-code-plugins/blob/7787be41e98e30cd6e3b82e99494886d77e30895/plugins/knowledge/skills/video-digest/extraction/watch/vision-gated-promote.js#L93-L107
Suggested fix
Wrap the call in try/catch, write error.message with writeStderr, and process.exit(1), as vision-gated-promote.js does. Add a CLI test with a claim inventory that parses to zero sessions asserting a one-line stderr and a nonzero exit.
Related
- #6813 (session-coverage gates and a zero-session inventory)
🤖 Generated with Claude Code
- Dominant language
- Shell
- Stars
- 22
- Forks
- 2
- Avg merge
- 6h 42m
- Merged PRs (30d)
- 902
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from melodic-software/claude-code-plugins
-
needs-triage priority: medium
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
melodic-software/claude-code-plugins#7288 · 1 comment ·
Maintainers usually reply within 1 day
-
knowledge: docpage-digest dual verification defines no verdict vocabulary or pass/fail thresholdOpenneeds-human needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
melodic-software/claude-code-plugins#7286 · 1 comment ·
Maintainers usually reply within 1 day
-
needs-triage priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
melodic-software/claude-code-plugins#7282 · 1 comment ·
Maintainers usually reply within 1 day
-
needs-triage priority: medium
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
melodic-software/claude-code-plugins#7273 · 1 comment ·
Maintainers usually reply within 1 day
-
needs-human needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
melodic-software/claude-code-plugins#7232 · 1 comment ·
Maintainers usually reply within 1 day
All issues in melodic-software/claude-code-plugins
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
sclorg/s2i-ruby-container#660 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
wazuh/wazuh-docker#2732 ·
Maintainers usually reply within 1 day
-
Route 53 DNS analytics/insights adds an observability signal for the DNS layerPossibly taken A pull request linked to this issue is open or already merged. Opendocumentation enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100