Factor out `MatrixFederationAgent`

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
28/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
networking

Research direction

Compare sydent/sydent/http/matrixfederationagent.py with synapse/synapse/http/federation/matrix_federation_agent.py to identify the shared implementation. Then review synapse/tests/http/test_proxyagent.py and synapse/tests/http/federation/test_matrix_federation_agent.py, including their MatrixFederationAgentTests classes. Done means the common code is factored out and the relevant tests still pass.

Written by the indexing model from the issue text.

Description

Sydent: sydent/sydent/http/matrixfederationagent.py
synapse: synapse/synapse/http/federation/matrix_federation_agent.py

And possibly these two in Synapse too?

synapse/tests/http/test_proxyagent.py
211:class MatrixFederationAgentTests(TestCase):

synapse/tests/http/federation/test_matrix_federation_agent.py
64:class MatrixFederationAgentTests(unittest.TestCase):
Dominant language
Python
Stars
4
Forks
7
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from matrix-org/matrix-python-common

All issues in matrix-org/matrix-python-common

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.