Common function `_reject_invalid_json` in both Synapse and Sygnal

Open
#13 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start by locating _reject_invalid_json in Synapse and Sygnal and comparing its implementations and callers. Determine how the common behavior could be shared, then verify that existing behavior remains covered by the relevant tests; done means the duplicated function is no longer maintained separately.

Written by the indexing model from the issue text.

Description

Noting common function _reject_invalid_json in both synapse and sygnal

Originally posted by @H-Shay in https://github.com/matrix-org/matrix-python-common/issues/1#issuecomment-966597137

Dominant language
Python
Stars
4
Forks
7
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from matrix-org/matrix-python-common

All issues in matrix-org/matrix-python-common

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.