Technical Indicators incorrect Time Conversion

Open
#689 1 comment 0 reactions 1 assignee View on GitHub

@justinpolygon is already working on this.

Since Jun 22, 2024.

Assessment

This issue has not been assessed yet.

Description

bug

Describe the bug
The time conversion is done from datetime when querying for technical indicators is to a nanoseconds resolution which conflicts with what Polygon is expecting (milliseconds). This, in turn, leads to Polygon thinking the wrong period is queried.

Code Links

As you can see, this is different from the way say the Aggregates call is done:
https://github.com/polygon-io/client-python/blob/b47b85245c24dcfd116ee93338ceba0c5f341f77/polygon/rest/aggs.py#L41-L45

The aggregates call is the right way. The SMA indicator also expects a millisecond timestamp: https://polygon.io/docs/stocks/get_v1_indicators_sma__stockticker

Dominant language
Python
Stars
1.5k
Forks
362
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from massive-com/client-python

All issues in massive-com/client-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.