Decoding JSON response errors should include the URL

Open
#1,031 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
72/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
api

Research direction

Start in base.py at the JSON response decoding log, then search for other JSON decoding errors where URL context may help. Review how full_url is available at each location and update the relevant messages to include it. Done means the affected error logs identify the response URL without changing the underlying error handling.

Written by the indexing model from the issue text.

Description

enhancement

Is your feature request related to a problem? Please describe.
In base.py, errors when decoding JSON responses don't include the URL:
logger.error("Error decoding json response: %s", e)

This can make it very difficult to troubleshoot corner-case issues.

Describe the solution you'd like
Include the URL. In this case, something like this would be very helpful:
logger.error("Error decoding json response [%s]: %s", full_url, e)

Please identify all such places where URL context is helpful and include the URL.

Dominant language
Python
Stars
1.5k
Forks
362
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from massive-com/client-python

All issues in massive-com/client-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.