Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

On Windows, diagnostics are show at the incorrect position after a custom tag

Open
  • Is something wrong?
#240 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript, vscode
Domain
devtools

Research direction

Reproduce the issue in the Marko VSCode extension on Windows using the template and dependency versions shown, then compare the rendered diagnostics with marko-type-check. Done means every instance of input.name++ is underlined at its correct position after the custom tag is present.

Written by the indexing model from the issue text.

Description

On Windows, after a custom tag is used, the diagnostics are shown at the incorrect positions or not shown at all. marko-type-check still shows the correct errors in the correct positions.

Given the following template, every instance of input.name++ should have an error underline.

export interface Input {
    name?: string;
}
<my-title name=input.name/>
<div>${input.name++}</div>
$ input.name++;
<div>${input.name++}</div>

The error is shown in the wrong position and only once:

export interface Input {
    name?: string;
}
<my-title name=input.name/>
<div>${input.name++}</div>
$ input.name++;
<div>${input.name++}</div>
 ^ 'input.name' is possibly 'undefined'.

Moving the use of <my-title> below the errors will cause the diagnostics above to be correctly rendered and the diagnostics below to be ignored.

export interface Input {
    name?: string;
}
<div>${input.name++}</div>
       ^^^^^^^^^^ 'input.name' is possibly 'undefined'.
<my-title name=input.name/>
$ input.name++;
<div>${input.name++}</div>

Removing the use of <my-title> shows all of the diagnostics in the right places as expected:

export interface Input {
    name?: string;
}
<div>${input.name++}</div>
       ^^^^^^^^^^ 'input.name' is possibly 'undefined'.
$ input.name++;
  ^^^^^^^^^^ 'input.name' is possibly 'undefined'.
<div>${input.name++}</div>
       ^^^^^^^^^^ 'input.name' is possibly 'undefined'.
Environment

Windows :(
Marko VSCode v1.1.15
VSCode 1.85.1

    "marko": "^5.32.2",
    "@marko/run": "^0.4.0",
    "@marko/type-check": "^1.0.7",
    "typescript": "^5.3.3"
Dominant language
TypeScript
Stars
44
Forks
12
Avg merge
3m
Merged PRs (30d)
8

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from marko-js/language-server

All issues in marko-js/language-server

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.