[proposal] migrate to golangci-lint

Open
#30 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
go
Domain
ci-cd, tooling

Research direction

Start with .travis.yml at line 11 and review how gometalinter is installed and invoked. Compare the current CI and Docker linting setup with golangci-lint, then consider the migration complete when the replacement runs successfully in those workflows.

Written by the indexing model from the issue text.

Description

I'm happy to do this work, but thought I'd open it as an issue first to see if you're even interested in the change. I propose a swap over to golangci-lint over gometalinter.

The two main reasons for this change are:

  • It's substantially better performing, works better in a Go 1.11 ecosystem (although they're still working with some linters to get them up to snuff, so it's a work in progress)
  • Can be installed via shell, which improves usage and start time in CI and Docker

I could list more reasons, but at that point it's just getting to my personal thoughts on one tool over another.

Would you be open to me swapping the tools out? For the first

Dominant language
Go
Stars
196
Forks
32
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from markbates/refresh

All issues in markbates/refresh

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.