Invalid CommandEnv & os.Environ priority

Open Beginner friendly
#26 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
62/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
go
Domain
cli

Research direction

Open refresh/runner.go at line 48 and inspect how CommandEnv is assigned to the command environment. Verify the intended precedence between os.Environ and CommandEnv, then confirm that local command variables override global values.

Written by the indexing model from the issue text.

Description

https://github.com/markbates/refresh/blob/4a017449d85be7e77ec41bb7327e10151ffba6e0/refresh/runner.go#L48

Must be

	cmd.Env = append(os.Environ(), m.CommandEnv...)

because local variables should override global

Dominant language
Go
Stars
196
Forks
32
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from markbates/refresh

All issues in markbates/refresh

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.