Source value mapped more than once inspection for @ValueMapping
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 75/100
Research direction
Start with src/main/java/org/mapstruct/intellij/inspection/TargetPropertyMappedMoreThanOnceInspection.java, which provides the existing inspection pattern. Trace how it detects duplicate normal mappings, then apply the same approach to @ValueMapping source values. Done means duplicate source values are recognized and reported with the expected error message.
Written by the indexing model from the issue text.
Description
For value mappings a source value can only be mapped once. For example
import org.mapstruct.Mapper;
import org.mapstruct.ValueMapping;
@Mapper
public interface ValueMapper {
enum A {
A,B
}
enum B {
A,B
}
@ValueMapping(source = "A", target = "B")
@ValueMapping(source = "A", target = "A")
A from(B b);
}
is invalide as source A is mapped twice. MapStruct report this as
Source value mapping: "A" cannot be mapped more than once.
Currently the plugin does not recognize this as an error. An inspection should be added for this.
For normal mappings there is already an inspection implemented and could be used as an example: https://github.com/mapstruct/mapstruct-idea/blob/main/src/main/java/org/mapstruct/intellij/inspection/TargetPropertyMappedMoreThanOnceInspection.java.
- Dominant language
- Java
- Stars
- 168
- Forks
- 41
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapstruct/mapstruct-idea
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
mapstruct/mapstruct-idea#274 · 2 comments ·
-
feature hack.commit.push
Difficulty 3/5 1-2 days Newbie friendliness 68/100
mapstruct/mapstruct-idea#267 ·
-
feature hack.commit.push
Difficulty 3/5 1-2 days Newbie friendliness 55/100
mapstruct/mapstruct-idea#266 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
mapstruct/mapstruct-idea#257 · 1 comment ·
-
hack.commit.push
Difficulty 5/5 Over a week Newbie friendliness 20/100
mapstruct/mapstruct-idea#256 ·
All issues in mapstruct/mapstruct-idea
Similar issues
-
bug untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
opensearch-project/ml-commons#5094 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
emitter:client:csharp feature
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
affects/8.10 affects/8.9 component/clients kind/bug likelihood/mid severity/mid
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Two open-case totals on one screen: the Programs tile says 15,858 and the nav badge says 15,868 Openbug frontend maui-pilot
Difficulty 2/5 1-3 hours Newbie friendliness 72/100