[Feature Request] Support for mapstruct-spi-protobuf

Open
#106 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
developer-experience

Research direction

Start by examining how the IntelliJ plugin detects unmapped target properties and compare that behavior with the compiler when using the mapstruct-spi-protobuf integration. Done means the plugin no longer reports a warning for protobuf-generated classes when the SPI makes the mapping valid.

Written by the indexing model from the issue text.

Description

Protobuf is widely used in the industry and often we need to convert proto generated classes to/from POJOs (or models generated by Lombok/AutoValue/Immutables/YouNameIt).

While it would be awesome for MapStruct to provide out of the box integration with Protobuf like Lombok. Before that it seems that the next best choice is to use this SPI https://github.com/entur/mapstruct-spi-protobuf.

This SPI solves the compile time problem where MapStruct thinks there are unmapped target properties.

However the Idea plugin is not recognizing the SPI and still shows a warning. It would be super nice the plugin would match the complier's behaviour in that.

Dominant language
Java
Stars
168
Forks
41
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mapstruct/mapstruct-idea

All issues in mapstruct/mapstruct-idea

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.