Add `install_requires` to `setup.py`
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- python
- Domain
- build-system
Research direction
Start with setup.py lines 34-80 and compare its setup() arguments with requirements.txt. Test the README pip-install command in a clean environment, then run the seamseg scripts to confirm the listed dependencies are installed automatically without manual torch, umsgpack, or inplace_abn installation.
Written by the indexing model from the issue text.
Description
Issue summary
In the README's setup section, it says:
or, in a single line:
pip install git+https://github.com/mapillary/seamseg.git
But, since setuptools.setup() does not include the install_requires argument, the projects dependencies do not get installed.
https://github.com/mapillary/seamseg/blob/3d10aea4442f76a29ac4a59340f6d2049c3986e5/setup.py#L34-L80
The pip install one-liner ends in errors for me unless I install torch myself. And even when I do that, when I try to run the seamseg scripts, I hit errors because dependencies like umsgpack and inplace_abn are not installed.
Possible solution
Could we add something like this?
...
requirements = []
with open("requirements.txt") as f:
requirements = f.read().splitlines()
setuptools.setup(
...
# Requirements
setup_requires=["setuptools_scm"],
python_requires=">=3, <4",
install_requires=requirements,
...
)
- Dominant language
- Python
- Stars
- 301
- Forks
- 53
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapillary/seamseg
-
ImportError during testing pre-trained model with test_panoptic.py, possibly a circular import?Open
Difficulty 4/5 3-5 days Newbie friendliness 38/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
-
Creating a ColabOpen
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 38/100
All issues in mapillary/seamseg
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-2 days Newbie friendliness 70/100
-
FingerprintSplitter raises ZeroDivisionError when int(frac_train * len(dataset)) floors to zeroOpen
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 7 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
lmstudio-ai/mlx-engine#376 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
pyiron/bagofholding#166 ·