v2 values of some type are ignored
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start at include/mapbox/vector_tile/builder.hpp lines 96-99 and inspect how the listed value types are handled. Determine whether ignoring null_value_t, recursive vector values, and recursive unordered-map values is intentional; then document the behavior if it is correct, or define the needed change and verify it with the existing test suite.
Written by the indexing model from the issue text.
Description
https://github.com/mapbox/vector-tile/blob/2.x/include/mapbox/vector_tile/builder.hpp#L96-L99
Values of type null_value_t, mapbox::util::recursive_wrapper<std::vector<value>>, and mapbox::util::recursive_wrapper<std::unordered_map<std::string, value>>> are simply ignored here. If this is correct, it needs to be documented.
- Dominant language
- C++
- Stars
- 52
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapbox/vector-tile
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
mapbox/vector-tile#46 · 4 comments · 4 reactions ·
-
1.x
Difficulty 4/5 3-5 days Newbie friendliness 25/100
mapbox/vector-tile#45 · 5 comments ·
-
2.x
Difficulty 5/5 Over a week Newbie friendliness 20/100
mapbox/vector-tile#43 ·
-
2.x
Difficulty 5/5 Over a week Newbie friendliness 30/100
mapbox/vector-tile#42 ·
-
Add OverzoomingOpen2.x
Difficulty 5/5 Over a week Newbie friendliness 25/100
mapbox/vector-tile#41 ·
All issues in mapbox/vector-tile
Similar issues
-
bug chart-audit
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
godotengine/godot#124120 ·
Maintainers usually reply within 1 day
-
Component: R Type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
apache/arrow#51695 · 1 comment ·
Maintainers usually reply within 1 day
-
HasBacktrace Priority-Critical
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
azerothcore/azerothcore-wotlk#27921 ·
Maintainers usually reply within 1 day
-
area/ysql kind/bug priority/medium
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
yugabyte/yugabyte-db#34584 ·
Maintainers usually reply within 1 day