IDs ignored
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
Research direction
Read include/mapbox/vector_tile/builder.hpp at lines 48-59 to verify how negative IDs and IDs not typed as int64_t or uint64_t are handled. Confirm whether this behavior is intentional, then document the supported and ignored ID types; done means the documented behavior matches the implementation.
Written by the indexing model from the issue text.
Description
IDs < 0 and IDs not of type int64_t or uint64_t are simply ignored here:
https://github.com/mapbox/vector-tile/blob/2.x/include/mapbox/vector_tile/builder.hpp#L48-L59
Is this correct? If yes, I think it needs to be documented.
- Dominant language
- C++
- Stars
- 52
- Forks
- 33
- PR merge metrics
- No merged PRs in 30d
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapbox/vector-tile
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
mapbox/vector-tile#46 · 4 comments · 4 reactions ·
-
1.x
Difficulty 4/5 3-5 days Newbie friendliness 25/100
mapbox/vector-tile#45 · 5 comments ·
-
2.x
Difficulty 5/5 Over a week Newbie friendliness 20/100
mapbox/vector-tile#43 ·
-
2.x
Difficulty 5/5 Over a week Newbie friendliness 30/100
mapbox/vector-tile#42 ·
-
Add OverzoomingOpen2.x
Difficulty 5/5 Over a week Newbie friendliness 25/100
mapbox/vector-tile#41 ·
All issues in mapbox/vector-tile
Similar issues
-
Difficulty 2/5 Half a day Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
ROCm/rocm-libraries#12703 ·
Maintainers usually reply within 2 days
-
bug
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
isl-org/Open3D#7585 · 1 comment ·
Maintainers usually reply within 2 days
-
Feature request
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
qbittorrent/qBittorrent#24975 ·
Maintainers usually reply within 3 days