Update mkdirp dev dep
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- javascript, node.js
Research direction
Read test/write.test.js and compare its mkdirp calls with the proposed promise-based patch. Verify the write tests pass with the updated mkdirp development dependency and that errors still surface as expected.
Written by the indexing model from the issue text.
Description
This simple patch seems enough:
--- a/test/write.test.js
+++ b/test/write.test.js
@@ -25,8 +25,7 @@
var dest2 = path.join(__dirname,'tmp', 'aync-copy',name);
mkdirp.sync(path.dirname(dest));
mkdirp.sync(path.dirname(dest2));
- mkdirp(path.dirname(dest), function(err) {
- if (err) throw err;
+ mkdirp(path.dirname(dest)).then(() => {
if (path.extname(name)) {
zf.readFile(name, function(err, buffer) {
if (err) throw err;
@@ -48,6 +47,8 @@
});
});
}
+ }).catch( err => {
+ throw err;
});
});
});
- Dominant language
- C++
- Stars
- 101
- Forks
- 42
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapbox/node-zipfile
-
npm install构建失败 Open
Difficulty 4/5 3-5 days Newbie friendliness 20/100
mapbox/node-zipfile#87 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
mapbox/node-zipfile#86 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
mapbox/node-zipfile#83 · 2 reactions ·
All issues in mapbox/node-zipfile
Similar issues
-
ai_reviewed
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
ydb-platform/ydb#53869 · 3 comments ·
-
bug cert blocker needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
project-chip/connectedhomeip#74373 ·
-
upstream update
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
conan-io/conan-center-index#31035 ·
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 85/100
vllm-project/vllm-ascend#17329 ·