Fail to build with Node.js ≥ 12
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp, node.js
- Domain
- build-system
Research direction
Start by reproducing the build with Node.js ≥ 12 and inspect src/node_zipfile.cpp, especially the TOSTR macro at line 23. Compare its V8 API usage with the compiler errors, then verify that the native module builds successfully with the affected Node.js versions.
Written by the indexing model from the issue text.
Description
Hi,
when building with Node.js ≥ 12, I got some errors:
/usr/include/nodejs/deps/v8/include/v8.h:2588:31: note: candidate: ‘v8::Local<v8::String> v8::Value::ToString(v8::Isolate*) const’
2588 | Local<String> ToString(Isolate* isolate) const);
| ^~~~~~~~
/usr/include/nodejs/deps/v8/include/v8config.h:311:3: note: in definition of macro ‘V8_DEPRECATED’
311 | declarator __attribute__((deprecated(message)))
| ^~~~~~~~~~
/usr/include/nodejs/deps/v8/include/v8.h:2588:31: note: candidate expects 1 argument, 0 provided
2588 | Local<String> ToString(Isolate* isolate) const);
| ^~~~~~~~
/usr/include/nodejs/deps/v8/include/v8config.h:311:3: note: in definition of macro ‘V8_DEPRECATED’
311 | declarator __attribute__((deprecated(message)))
| ^~~~~~~~~~
../src/node_zipfile.cpp:23:56: error: no matching function for call to ‘v8::Value::ToString()’
23 | #define TOSTR(obj) (*String::Utf8Value((obj)->ToString()))
- Dominant language
- C++
- Stars
- 101
- Forks
- 42
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapbox/node-zipfile
-
npm install构建失败 Open
Difficulty 4/5 3-5 days Newbie friendliness 20/100
mapbox/node-zipfile#87 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
mapbox/node-zipfile#86 ·
-
Difficulty 1/5 1-3 hours Newbie friendliness 35/100
mapbox/node-zipfile#85 ·
All issues in mapbox/node-zipfile
Similar issues
-
ai_reviewed
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
ydb-platform/ydb#53869 · 3 comments ·
-
bug cert blocker needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
project-chip/connectedhomeip#74373 ·
-
upstream update
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
conan-io/conan-center-index#31035 ·
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 85/100
vllm-project/vllm-ascend#17329 ·