Memory leak
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- ios, swift
- Domain
- computer-graphics, mobile-dev, performance
Research direction
Start by tracing annotationManager's handling of nodes during session.pause() from the AR view controller's viewDidDisappear and during removeAllAnnotations. Reproduce repeated UIPopoverPresentationController presentation and dismissal, then verify that resources are released and the repeated flow no longer reaches the CoreAnimation IOSurface allocation failure.
Written by the indexing model from the issue text.
Description
I am encountering a persistent memory allocation issue with this otherwise awesome library.
Specifically, when a UIPopoverPresentationController (showing a modal VC with extended data on a given node, in response to user interaction) is presented and dismissed repeatedly, the app crashes with a [Render] CoreAnimation: failed to allocate IOSurface error.
This appears to be an issue related to the handling of nodes on calling the session.pause() method from the AR VC's viewDidDisappear code. I suspect this problem is related to the the issue discussed here:
https://stackoverflow.com/questions/28738551/how-can-i-remove-all-nodes-from-a-scenekit-scene
It looks like the annotationManager class here is not fully deallocating resources when the session is paused (nor on on calling removeAllAnnotations). Unfortunately I haven't been able to resolve this based on the SO answer.
- Dominant language
- Swift
- Stars
- 227
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapbox/mapbox-arkit-ios
-
Difficulty 5/5 Over a week Newbie friendliness 10/100
mapbox/mapbox-arkit-ios#46 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 20/100
mapbox/mapbox-arkit-ios#45 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
mapbox/mapbox-arkit-ios#43 ·
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
mapbox/mapbox-arkit-ios#42 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
mapbox/mapbox-arkit-ios#41 ·
All issues in mapbox/mapbox-arkit-ios
Similar issues
-
area: browser area: cli
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
manaflow-ai/cmux#25105 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
521xueweihan/HelloGitHub#4101 ·
-
bug mac-app
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
element-hq/element-x-ios#6405 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
apple/coreai-models#380 ·
Maintainers usually reply within 1 day