Add support to changelog-draft for non-squash merge strategies

Open
#3 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
git, github, javascript
Domain
release, tooling

Research direction

Start by locating the changelog-draft code that searches for pull requests using merge_commit_sha, then trace how associated commits are collected. Review the GitHub pull request data and merge strategies involved. Done means non-squash merges no longer leave applicable commits unassociated; add or update coverage if the project has tests for this behavior.

Written by the indexing model from the issue text.

Description

We're currently looking up a commit's associated PR by searching for a PR with a matching merge_commit_sha field. This works well for squash-merged PRs, but in other cases, it leaves us with a bunch of unassociated commits (i.e. the ones that aren't the merge commit or the head of the rebased-and-ff-merged branch).

Dominant language
JavaScript
Stars
16
Forks
5
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mapbox/github-release-tools

All issues in mapbox/github-release-tools

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.