Request review from original PR author when backporting a PR you reviewed

Open
#24 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
release

Research direction

Start by tracing the backport flow that requests reviews on the new pull request. Reproduce the case where the backporter approved the original pull request, then verify that the request targets the original author rather than the backporter and that GitHub no longer rejects it.

Written by the indexing model from the issue text.

Description

Currently if you backport a PR of behalf of someone else, and you were the approving reviewer on the original PR, backport will attempt to request a review on the new PR from yourself, which Github denies:

{ HttpError: {"message":"Review cannot be requested from pull request author.","documentation_url":"https://developer.github.com/v3/pulls/review_requests/#create-a-review-request"}
...

It should instead request a review from the original author.

Dominant language
JavaScript
Stars
16
Forks
5
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mapbox/github-release-tools

All issues in mapbox/github-release-tools

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.