Fail or warn when module isn't found?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript
Research direction
No file, test, or entry point is named. Start by locating the code that handles a module missing from the node_modules tree and review how its exit status and output are tested. Done means the project has a decided fail-or-warn behavior, matching output, and coverage for the missing-module case.
Written by the indexing model from the issue text.
Description
Right now if a module isn't found, we exit 1 and fail. Output looks like this:
Checking for duplicate modules ...
tilelive was not found in the node_modules tree
Alternatively, we could just print a warning since this isn't necessarily a bad thing, it just means the module isn't being installed (presumably because it's not longer being used). Output could instead look like:
Checking for duplicate modules ...
✔ @mapbox/vtquery has only one version
? tilelive was not found in the node_modules tree
cc @mapbox/core-tech
- Dominant language
- JavaScript
- Stars
- 1
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapbox/duplicate-module-test
-
Difficulty 1/5 Under an hour Newbie friendliness 42/100
All issues in mapbox/duplicate-module-test
Similar issues
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 92/100
PedestrianDynamics/pyFDS-Evac#476 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
aiko-chan-ai/DiscordBotClient#380 ·
-
Offisielle trærOpen
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 3 days
-
Add: Atlas TVOpenchannels:add check:passed
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 4 days