Do we need to resolve custom properties?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- css
- Domain
- build-system, frontend
Research direction
No file or test is named. Start by reviewing how the build system handles the variables option and the browser support targets referenced in pull request #970; compare resolving variables at build time with emitting :root custom properties, including first-paint and compressed-size effects. Done means reaching a documented decision on whether to change the build behavior.
Written by the indexing model from the issue text.
Description
With https://github.com/mapbox/assembly/pull/970 - our browser support targets all support css custom properties. Should we revise our build system to convert the variables option to a set of :root CSS properties? Would save us from needing to resolve every variable in our CSS at build time.
Are there costs to doing this? Likely compressed file size would not be impacted but could time to first paint take a hit? Here's an article on CSS variable performance, but it exclusively discusses the performance of changing variables at runtime: https://lisilinhart.info/posts/css-variables-performance/ and after some quick looking, couldn't find any existing documentation of the performance cost of using variables.
- Dominant language
- CSS
- Stars
- 138
- Forks
- 26
- Avg merge
- 20m
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapbox/assembly
-
Difficulty 2/5 1-3 hours Newbie friendliness 30/100
-
2 estimate-2 icebox jira-sync-complete p2
Difficulty 2/5 1-3 hours Newbie friendliness 38/100
-
2 architecture enhancement estimate-4 icebox jira-sync-complete needs research p2 p3
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
dunkagroo estimate-2 jira-sync-complete p2
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
2 dunkagroo estimate-2 estimate-4 icebox jira-sync-complete p2
Difficulty 5/5 Over a week Newbie friendliness 30/100
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
open-telemetry/opentelemetry-go-compile-instrumentation#1450 ·
Maintainers usually reply within 2 days
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
bazel-contrib/rules_go#4736 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
-
good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day