Invalid characters in MC break search API
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start by reproducing the search request with the message containing control and zero-width characters, comparing the Python client's response with the working requests and ujson path shown in the issue. Trace how the client parses the search response and verify that the returned hits are exposed instead of becoming None.
Written by the indexing model from the issue text.
Description
Adding messages like this to MC seems to break the ability of the client to fetch them:
'msg': '[\x02L\u200bi\u200bl\u200bB\u200br\u200bu\u200bc\u200be\x02] sss'
Indexing with the client works fine:
{'error': None,
'items': [{'bulk': {'_id': 1370872170497990695,
'_index': 'main',
'created': 1,
'deleted': 0,
'result': 'created',
'status': 201,
'updated': 0}}]}
However, on search, these are the results:
{'took': None, 'timed_out': None, 'aggregations': None, 'hits': None, 'profile': None, 'warning': None}
In the server query log at the same time, I can see that this did in fact return results the client is not displaying.
/* Thu Sep 8 14:54:48.419 2022 conn 2 real 0.001 wall 0.002 found 73
Using requests seems to work:
response = requests.post(f"{settings.MANTICORE_URL}/json/search", json=search_query)
response = ujson.loads(response.text)
- Dominant language
- Python
- Stars
- 62
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from manticoresoftware/manticoresearch-python
-
`UtilsApi` will return MVA type list value as stringMay be free again @Nick-S-2018 claimed this 890 days ago, and no pull request is open. Open
manticoresoftware/manticoresearch-python#14 · 5 comments · 1 assignee ·
All issues in manticoresoftware/manticoresearch-python
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
data-umbrella/du-event-board#225 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100