[P3] sprites.test.ts drives every room kind at the retired 11px tile
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- testing
Research direction
Start in src/render/sprites.test.ts, especially the drawUnit cases at lines 162-272, and compare them with the TILE and FLOOR world constants and facilityFloors(kind). Restate each room rectangle using those values, then run the sprites test suite. Done means the cases cover the shipped room dimensions rather than retired 11px geometry.
Written by the indexing model from the issue text.
Description
Deferred from the gds-code-review of the room occupant seats fix (PR for #813). Pre-existing, not introduced by that change.
src/render/sprites.test.ts still drives every room kind at the retired 11px tile. Rects of 132x44, 176x44, 220x44 and 88x44 run through drawUnit at lines 162-272: geometry the renderer no longer produces, since the world moved to TILE 10 by FLOOR 45. A suite that exercises sizes the game never renders can pass while the shipped sizes are broken, which is plausibly part of why the #813 under-draws went unnoticed for so long.
The one case #813 touched was moved to roomCapacity.test.ts at the bay's real rect. The rest wants its own sweep: restate each rect as width * TILE by facilityFloors(kind) * FLOOR so the suite follows the world constants instead of pinning history.
Severity low, but it is a live blind spot in a guard suite, not a style nit.
- Dominant language
- TypeScript
- Stars
- 5
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from maniator/verticopolis
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
maniator/verticopolis#833 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
maniator/verticopolis#829 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
maniator/verticopolis#822 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
maniator/verticopolis#814 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
maniator/verticopolis#799 · 1 comment ·
All issues in maniator/verticopolis
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100