[P2] The sprite-review pages render at retired scales, so art is vetted at the wrong aspect
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start with src/render/scale.ts to identify the current scale values, then inspect the constants in src/preview.ts and src/gallery.ts. Update both sprite-review pages to derive their tile and floor dimensions from the shared scale source, and verify that their rendered proportions match the current game aspect.
Written by the indexing model from the issue text.
Description
Found by the adversarial review on PR #811.
src/preview.ts:45,79-80 uses const TILE = 12; // matching the game scale feel and const h = 44; (44 is exactly the retired FLOOR). preview.html is a shipped, screenshotted page whose job is showing room art at game proportions, and it now shows 12 x 44, which is 3.67 tiles per floor against a world of 4.5.
src/gallery.ts:61-63 has the same problem independently (tile 18, floor 52, so 2.9 tiles per floor). Pre-existing, and now further off.
This matters more than it looks: these are the pages an artist uses to judge room art, so any art vetted through them is vetted at the wrong aspect, which is the exact error the scale change exists to correct. Fix this BEFORE the room-density and palette work in the visual-parity GDD, or that work is judged against a lie.
Derive both from src/render/scale.ts rather than restating numbers.
- Dominant language
- TypeScript
- Stars
- 5
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from maniator/verticopolis
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
maniator/verticopolis#833 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
maniator/verticopolis#830 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
maniator/verticopolis#829 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
maniator/verticopolis#822 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
maniator/verticopolis#799 · 1 comment ·
All issues in maniator/verticopolis
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100