Dependency on Magento was sneaked in as part of the Computed Resolver work
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start by reviewing the Computed Resolver change in commit 6d25b499134ceb4b4046ab996b8652e008c854f and inspect Magento\UpwardConnector\Model\ComputedPool and Magento\UpwardConnector\Api\ComputedInterface. Determine whether the interface should be introduced in the standalone package or whether the Magento implementation belongs there. Done means the package no longer hardcodes a Magento dependency while preserving the computed resolver contract.
Written by the indexing model from the issue text.
Description
This package has no declared composer dependencies on Magento, yet in https://github.com/magento/upward-php/commit/6d25b499134ceb4b4046ab996b8652e008c854f0 a dependency is hardcoded.
This means that it cannot be considered anymore as a standalone implementation of upward in PHP.
Following Dependency Inversion principle we should create an interface which \Magento\UpwardConnector\Model\ComputedPool implements, or make \Magento\UpwardConnector\Model\ComputedPool part of the magento/upward-php together with \Magento\UpwardConnector\Api\ComputedInterface.
- Dominant language
- PHP
- Stars
- 14
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from magento/upward-php
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
magento/upward-php#91 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
magento/upward-php#88 · 2 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
magento/upward-php#85 ·
-
Add Caching HeadersOpen
Difficulty 5/5 Over a week Newbie friendliness 25/100
magento/upward-php#52 · 1 comment · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
magento/upward-php#29 ·
All issues in magento/upward-php
Similar issues
-
Awaiting Triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 2 days
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
openemr/openemr#14857 · 1 reaction ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
type: enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100