Deeplink parameter makes Lyft app crash
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 15/100
Research direction
Start by reproducing the reported deeplink with only pickup[address] and compare it with the logged redirect and Android stack trace. The trace names MainActivity, DeepLinkManager, GenericDeepLinkRouter, and RideTypesDeepLinkRoute, but the report does not identify a repository file or test; confirm whether this SDK owns the crash before defining a fix and acceptance test.
Written by the indexing model from the issue text.
Description
If I specify only pickup[address] the Lyft app crashes with this error:
06-18 23:06:50.786 27039-27039/? E/AndroidRuntime: FATAL EXCEPTION: main
Process: me.lyft.android, PID: 27039
java.lang.RuntimeException: Unable to resume activity {me.lyft.android/me.lyft.android.ui.MainActivity}: java.lang.NullPointerException
at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3103)
at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3134)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1388)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5417)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)
Caused by: java.lang.NullPointerException
at com.lyft.common.Objects.c(SourceFile:71)
at me.lyft.android.ui.RideTypesDeepLinkRoute.forwardGeocode(SourceFile:178)
at me.lyft.android.ui.RideTypesDeepLinkRoute.route(SourceFile:97)
at com.lyft.android.deeplinks.GenericDeepLinkRouter.routeAction(SourceFile:63)
at com.lyft.android.deeplinks.GenericDeepLinkRouter.routeDeepLink(SourceFile:18)
at com.lyft.android.deeplinks.DeepLinkManager.a(SourceFile:68)
at com.lyft.android.deeplinks.DeepLinkManager.a(SourceFile:22)
at me.lyft.android.ui.MainActivity.checkForDeepLink(SourceFile:496)
at me.lyft.android.ui.MainActivity.onResume(SourceFile:326)
at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1258)
at android.app.Activity.performResume(Activity.java:6327)
Here is the log on my app (just before the crash):
I/Taxi: redirect to lyft://ridetype?id=lyft&pickup[address]=via borgo palazzo 1, Bergamo&destination[latitude]=45.467237&destination[longitude]=9.189705
I/ActivityManager: START u0 {act=android.intent.action.VIEW dat=lyft://ridetype?id=lyft&pickup[latitude]=via borgo palazzo 1, Bergamo&destination[latitude]=45.467237&destination[longitude]=9.189705 flg=0x10000000 cmp=me.lyft.android/.ui.MainActivity} from uid 10085 on display 0
I know it's not strictly related to this SDK but I didn't know where to open this elsewhere.
- Dominant language
- Java
- Stars
- 72
- Forks
- 21
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lyft/lyft-android-sdk
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
lyft/lyft-android-sdk#26 · 1 comment ·
-
Android 11 - It is not redirecting on browser and Lyft appMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
lyft/lyft-android-sdk#25 · 8 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
lyft/lyft-android-sdk#24 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
lyft/lyft-android-sdk#23 ·
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
lyft/lyft-android-sdk#10 · 1 reaction ·
All issues in lyft/lyft-android-sdk
Similar issues
-
priority: medium Review effort [1-5]: 3 status: needs-triage type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
carlos-emr/carlos#5431 ·
Maintainers usually reply within 1 day
-
Integration tests: jetty:run fails with WELD-001408 for CountryJpaServicePossibly taken @viniciusmachak claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
primefaces/primefaces#15431 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
OpenAPITools/openapi-generator#25454 ·
Maintainers usually reply within 1 day
-
Component - Build
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100