Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

input: allow Editor as the control of an InputGroup

Open Beginner friendly
  • Is something wrong?
#3,620 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
desktop, frontend

Research direction

Read crates/component/src/input/group.rs around InputGroupControl conversions and compare the Textarea path in crates/component/src/input/textarea.rs with how Editor exposes its state and options. Add an Editor conversion that preserves its options, then check that an Editor can be passed to InputGroup::input while retaining the group's frame and addons.

Written by the indexing model from the issue text.

Description

Description

InputGroup::input accepts only Input and Textarea, so an Editor cannot be framed by an InputGroup with addons. A chat-style composer whose body needs syntax highlighting therefore cannot reuse the group's frame, footer addons and focus treatment.

Internally, almost everything needed is already in place:

  • InputGroupControl wraps an Input (group.rs#L460-L473), with From<Input> and From<Textarea> only.
  • Textarea converts through the crate-private Textarea::into_input (textarea.rs#L185-L195).
  • Input::from_state is pub(crate). Its doc comment says Textarea and Editor both render through it.
  • TextInputState already has an Editor(Entity<EditorState>) variant (state.rs#L37-L41).

So the missing piece is an Editor → InputGroupControl conversion.

main still has only the Input and Textarea conversions.

Environment

  • GPUI: gpui-pre 0.3.9
  • GPUI Component: gpui-kit 0.8.0
  • Platform: macOS 27 (arm64)

Steps to Reproduce

let state = cx.new(|cx| EditorState::new(window, cx).language("bash"));
InputGroup::new("shell-composer")
    .input(Editor::new(&state))   // error: `From<Editor>` is not implemented for `InputGroupControl`
    .addon(InputGroupAddon::new("footer").align(InputGroupAddonAlignment::BlockEnd).child(footer));

Expected

An Editor can be the control of an InputGroup, just like Textarea. The group provides the frame, border, focus ring and addons, and the editor keeps its language, highlighting, soft wrap, submit_on_enter and other options.

Actual

It does not compile. The alternatives are drawing a separate frame that has to track the group's styling by hand, or placing a dummy Input in the group.

Suggested change

  • Add impl From<Editor> for InputGroupControl, mirroring the Textarea path (e.g. an Editor::into_input that carries the editor's options).
  • Optional: give Editor an auto-grow option like Textarea::auto_grow(min, max). When an editor is used as a composer body, it currently has to compute its own height from the display map.

Context: Gupi is adding a dedicated shell-command composer with Bash highlighting next to its normal message composer. For now it draws its own frame with the theme's input tokens.

Dominant language
Rust
Stars
18.2k
Forks
1.1k
Avg merge
14h 15m
Merged PRs (30d)
312

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from longbridge/gpui-kit

All issues in longbridge/gpui-kit

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.