Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

make decoder check size of string before parsing the json

Open
  • Is something wrong?
#28 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
ruby
Domain
backend

Research direction

Start in lib/logstash/codecs/json.rb around the parsing point linked in the issue and inspect how the codec currently handles incoming strings. Define the configurable default size limit and make oversized JSON refuse parsing; completion means the limit is enforced before parsing and the behavior is covered by the codec's tests.

Written by the indexing model from the issue text.

Description

discuss enhancement

This codec is a privileged position to avoid the creation of huge events from arbitrarily large json documents.
Although the string itself has been alocated, if this codec had a size limit, we could prevent further damage down the pipeline flow.

All we need is a setting that by default is limited to some size like 50k, and here we can loudly refuse to parse the json if the json.byte_size is beyond that limit.

Thoughts?

Dominant language
Ruby
Stars
26
Forks
27
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from logstash-plugins/logstash-codec-json

All issues in logstash-plugins/logstash-codec-json

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.