Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

macro arguments with comma not properly supported

Open
#129 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
ocaml
Domain
compilers

Research direction

Start by locating mldoc's macro argument parsing and reproduce the reported {{quote ...}} examples, especially the comma-containing quotation. The work is done when a quote containing commas can be passed without visible quotation marks while the author argument remains separate and existing macro behavior is preserved.

Written by the indexing model from the issue text.

Description

I have created a macro to quickly make quotations which should like this:

image

If I put the quote argument in quotation marks it looks like this (the quotation marks are shown):

{{quote "All models are wrong, but some are useful", George Box}}
image

But if I remove them, then it (of course) can't tell where the quote ends:

{{quote All models are wrong, but some are useful, George Box}}
image

It would be nice if the quotation marks could be removed. Is there a canonical way to do this?

Dominant language
OCaml
Stars
280
Forks
30
Avg merge
15m
Merged PRs (30d)
2

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from logseq/mldoc

All issues in logseq/mldoc

Similar issues

More Compilers issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.