`Matrix::orthogonalize()` works only for distributed case.

Open

#232 opened on Jul 29, 2023 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 1/5
Estimated time: Under an hour
Newbie friendliness: 45/100

Issue type: Bug
Clarity: Clearly specified
Activity status: Stale
Tech stack: cpp
Domain: distributed-systems

Research direction

Open lib/linalg/Matrix.cpp and inspect Matrix::orthogonalize(), focusing on its behavior for non-distributed matrices. Confirm the intended distributed-only precondition from the issue, then verify that the function rejects unsupported cases as described. Done means the stated validation is present and the relevant behavior is covered by the project's existing checks.

Written by the indexing model from the issue text.

Description

bug

Based on the definition in lib/linalg/Matrix.cpp, void Matrix::orthogonalize() works only when the matrix is distributed (in parallel case). It should have a line:

CAROM_VERIFY(distributed());

Dominant language: C++
Stars: 236
Forks: 47
PR merge metrics: No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

Use 4:4:4 for multichannel AVIF and HEIF gain maps Open

Difficulty 2/5 1-3 hours Newbie friendliness 70/100

google/libultrahdr#485 · Opened Sep 24, 2026
Missing tile warnings in TileMap dock display with wrong texture filter Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

godotengine/godot#123776 · Opened Sep 23, 2026
if(cond,a,b) treats any nonzero cond as true in every bngsim backend (ExprTk interpreter, C codegen, SSA), which contradicts docs/reference/expressions.md ('true when > 0.5') and BNG's run_network. A non-boolean condition in (-inf,0) or... Open

bug

Difficulty 1/5 Under an hour Newbie friendliness 60/100

lanl/bngsim#774 · Opened Sep 23, 2026
Delete ament_export_include_directories() and ament_export_libraries() calls Open

good first issue

Difficulty 1/5 Under an hour Newbie friendliness 90/100

ros2/rosbag2#2509 · Opened Sep 23, 2026
Delete ament_export_include_directories() and ament_export_libraries() calls Open

good first issue

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

ros2/common_interfaces#344 · Opened Sep 23, 2026

More C++ issues