Run all the Solidity tests with Foundry
@RiccardoBiosas is already working on this.
Since Jul 11, 2022.
Assessment
This issue has not been assessed yet.
Description
Context
At the moment the protocol code-base includes two types of Solidity tests: truffle-based Solidity tests and Foundry Solidity tests.. The truffle-based Solidity tests are run as part of the unit tests via the runSolidityTest helper.
I propose to convert them to Foundry tests to enforce more consistency in the code-base and because Foundry is the clear winner in terms of performance and testing capabilities.
TODO
- Move the Solidity tests to the Foundry directory
- Make the necessary refactoring to run them as tests with Foundry/forge - i.e.: replacing the
before,beforeEachhooks withsetUp. I'm estimating the refactoring process should be fairly straightforward - Remove the
runSolidityTesthelper
- Dominant language
- JavaScript
- Stars
- 155
- Forks
- 50
- PR merge metrics
- No merged PRs in 30d
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from livepeer/protocol
-
known-issue
Difficulty 4/5 3-5 days Newbie friendliness 30/100
-
Winning tickets can settle for less than their face value once the recipient’s reserve is exhaustedOpenknown-issue
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
blockchain enhancement pm
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
known-issue
Difficulty 5/5 Over a week Newbie friendliness 20/100
-
known-issue
Difficulty 5/5 Over a week Newbie friendliness 25/100
All issues in livepeer/protocol
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
hexlet-codebattle/codebattle#2361 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
micromatch/picomatch#223 ·
Maintainers usually reply within 11 days
-
Upgrade MongoDB Node.js driver to 7.6+ for full MongoDB 9.0 compatibilityPossibly taken @ga262 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
parse-community/parse-server#10754 · 1 comment ·
Maintainers usually reply within 1 day
-
🐛 bug
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
margelo/react-native-vision-camera#4211 ·
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
platformatic/platformatic#5161 · 1 comment ·
Maintainers usually reply within 1 day