[FEAT] Add CONTAINER_ID as filter

Open
#49 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Quiet
Tech stack
docker

Research direction

Start by reading the repository's existing request-filter configuration and the discussions in issues #12 and #13 to understand the prior decision. Done means the CONTAINER_ID setting clearly enables or disables /containers/{id}/ while preserving the proxy's security boundaries; the issue names no tests or files to run.

Written by the indexing model from the issue text.

Description

enhancement no-issue-activity
Is this a new feature request?
  • I have searched the existing issues
Wanted change

I'd like to introduce the CONTAINER_ID parameter as filter. This parameter needs to enable/disable the /containers/{id}/ endpoint.

Reason for change

This suggestion has been discussed in the past see #12 and #13 in 2024, however the treat landscape keeps changing and as adoption of this solution is picking up its becoming more relevant.

Today this container is being used often with solutions such as Traefik resulting in near public exposure of the socket-proxy. The /containers/{id}/ endpoint allows access to sensitive endpoint such as the ENV variables of a container. Therefore I'd like to ask you to reconsider earlier position as stated in the issues #12 and #13 and add this feature.

Proposed code change

No response

Dominant language
Dockerfile
Stars
317
Forks
13
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from linuxserver/docker-socket-proxy

All issues in linuxserver/docker-socket-proxy

Similar issues

More DevOps issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.