Option parsing bug for start-component.sh
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start at dynamometer-infra/src/main/java/com/linkedin/dynamometer/Client.java#L327 and inspect how start-component.sh options are parsed, especially the help check and flattening behavior. Reproduce the case with -hadoop_binary_path as the first option, then verify that it is not treated as help while genuine help input still behaves correctly.
Written by the indexing model from the issue text.
Description
This might be related with #52 .
In https://github.com/linkedin/dynamometer/blob/master/dynamometer-infra/src/main/java/com/linkedin/dynamometer/Client.java#L327 it is trying to find whether there is help option entered for the function, but internally it is using a GnuParser (which is deprecated from version 1.3), and during the flatten process it will try to pull the substring of -h from option -hadoop_binary_path and thinks it is asking for help information.
Note this only happens when you put the -hadoop_binary_path as the first option since other options will make the flatten end early.
- Dominant language
- Java
- Stars
- 134
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from linkedin/dynamometer
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
linkedin/dynamometer#106 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
linkedin/dynamometer#104 · 4 comments ·
-
Improve Dynamometer compatibility with the 2.x lineMay be free again @xkrogen claimed this 2626 days ago, and no pull request is open. Open
linkedin/dynamometer#101 · 2 comments · 1 assignee ·
-
Difficulty 3/5 1-2 days Newbie friendliness 30/100
linkedin/dynamometer#100 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
linkedin/dynamometer#81 · 1 comment ·
All issues in linkedin/dynamometer
Similar issues
-
type: possible bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
grimmory-tools/grimmory#2850 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
aoqia194/leaf-loader#19 ·