Configurable access and a review path so only the data team edits the semantic layer

Open
#32,515 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript

Research direction

Start by locating the Semantic Studio access and edit flows, then compare them with the existing AI writeback pull request flow. The issue does not name files or tests, and the configurable permissions, review routing, and product announcement need design decisions. Done means access is configurable and explicit, every edit goes through review, and the permission model is documented and announced.

Written by the indexing model from the issue text.

Description

✨ Feature Request 💜 Customer Support Advisory Call Request

Problem

Editing the semantic layer from the UI (Semantic Studio) appeared in a project menu without an announcement. A data lead who owns the model wants it clear, and enforceable, that only the data team can change the semantic layer: it is their source of truth, other teams can propose changes, the data team reviews and merges.

Ask

  • Make who can open and edit Semantic Studio explicit in the UI and configurable (developers and admins only, or a chosen group), and document it.
  • Route every edit from Semantic Studio through review (a pull request, as AI writeback already does), never straight to the live model, with the reviewing team configurable.
  • Announce the feature with the permission model stated up front. The first reaction from a careful team is "who else can touch this?".

Context

Raised on an advisory call. The customer's position: contributions welcome, direct edits not, and that won't change once more people understand the model. Related project: Semantic Layer Studio Editor.

Dominant language
TypeScript
Stars
6.2k
Forks
809
Avg merge
12h 13m
Merged PRs (30d)
854

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from lightdash/lightdash

All issues in lightdash/lightdash

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.