ISO sample delay

Open
#118 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
18/100
Issue type
Documentation
Clarity
Needs clarification
Activity status
Stale
Tech stack
c

Research direction

This is an open question, not a scoped change: it asks whether minimp3 compensates the filterbank/ISO decoder delay of 528 (plus one) samples or leaves it to the caller. Start in the single header minimp3.h, at the Layer III decode path around the IMDCT/synthesis filterbank and the frame loop that hands PCM to the caller, and compare with ISO 11172-3 on decoder delay. Done means a definitive answer, and if the delay is not applied, a documented note or an optional first-frame skip with a test decoding a known file.

Written by the indexing model from the issue text.

Description

Do you add the filterbank 528 sample delay or is it our responsability?

Dominant language
C
Stars
2k
Forks
271
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from lieff/minimp3

All issues in lieff/minimp3

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.