Docs: WithdrawalsFinalized includes both request ID endpoints

Open Beginner friendly
  • Is something wrong?
#1,033 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
94/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript
Domain
documentation

Research direction

Edit docs/contracts/withdrawal-queue-erc721.md in the claim section. Start by checking the range description against the linked contract emission and example transaction. Change (from, to] to [from, to]; done when the guide describes both request ID endpoints as included.

Written by the indexing model from the issue text.

Description

The WithdrawalQueueERC721 claim guide describes WithdrawalsFinalized(from, to, …) as covering (from, to]. The contract emits from as the first newly finalized request ID, so both endpoints are included. An indexer using the documented range would skip the first request in each batch.

For example, an Ethereum mainnet finalization emitted from = 141089 and to = 141196. The inclusive range has 108 requests. The documented range has 107 and omits 141089, which was successfully claimed.

Please change (from, to] to [from, to] in the source page.

Dominant language
JavaScript
Stars
61
Forks
82
Avg merge
1d 18h
Merged PRs (30d)
16

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from lidofinance/docs

All issues in lidofinance/docs

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.