cpu_features_get_perf_counter seems incorrect for macOS

Open
  • Is something wrong?
#223 0 comments 0 reactions 0 assignees View on GitHub

@voidsipp is already working on this.

Since Nov 3, 2026.

  • #235 by @voidsipp — open

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
c
Domain
performance

Research direction

Start in features/features_cpu.c, especially lines 155-214 and the macOS exclusion at lines 179-180. Compare how the x86 and arm64 architecture-specific cases handle cpu_features_get_perf_counter, then determine the appropriate macOS PowerPC behavior. Done means macOS is handled correctly rather than falling through without a case.

Written by the indexing model from the issue text.

Description

Looks like there is no case of macOS here:
https://github.com/libretro/libretro-common/blob/668749ae38a9e85744d1c15a652a1e8db8ab9e82/features/features_cpu.c#L155-L214

x86 and arm64 will use arch-specific cases, but for powerpc there is nothing, since macOS is excluded here: https://github.com/libretro/libretro-common/blob/668749ae38a9e85744d1c15a652a1e8db8ab9e82/features/features_cpu.c#L179-L180

Dominant language
C
Stars
183
Forks
99
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from libretro/libretro-common

All issues in libretro/libretro-common

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.