Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Max size restriction applied to whole message not just data

Open
  • Is something wrong?
#11 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
networking

Research direction

Start with src/mplex.js lines 84-93 and compare the incoming-message size check with the mplex specification's 1MB data-field limit. Confirm that message overhead does not trigger the restriction, and verify the resulting behavior with the repository's existing checks or test suite.

Written by the indexing model from the issue text.

Description

For incoming messages the max size restriction is applied to the whole message, not just the data field:

https://github.com/libp2p/pull-mplex/blob/master/src/mplex.js#L84-L93

The spec says that the data field can be up to 1MB so this will be causing false positives for certain message sizes.

Dominant language
JavaScript
Stars
5
Forks
1
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from libp2p/pull-mplex

All issues in libp2p/pull-mplex

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.