refresh Reference when commit with update_ref non-None

Open
#1,330 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
git, python
Domain
devtools

Research direction

Start at the repo.amend_commit(commit, branch, tree=tree) entry point and compare the Reference behavior before and after git_commit_amend. Check how branch.peel() is resolved when branch is a Reference or str; done means the supplied reference reflects the amended commit rather than the original one.

Written by the indexing model from the issue text.

Description

When repo.amend_commit(commit, branch, tree=tree), where branch is a Reference/str, the reference is update by libgit2 upon calling git_commit_amend.

However, the reference object branch still points to (branch.peel()) the original commit.

Dominant language
Python
Stars
1.7k
Forks
408
Avg merge
2d 57m
Merged PRs (30d)
7

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from libgit2/pygit2

All issues in libgit2/pygit2

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.