utf error when listing branches

Open
#1,206 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
git, python
Domain
devtools, tooling

Research direction

Start at pygit2/repository.py:1526 and inspect the iterator around _repository.listall_branches. Reproduce the failure with a branch name containing invalid UTF-8, then determine whether the intended behavior is to expose the invalid name or skip that branch. Done means the chosen behavior is implemented and verified for this case.

Written by the indexing model from the issue text.

Description

Hi,
when listing branches, we get

"/usr/local/lib/python3.8/site-packages/pygit2/repository.py", line 1526, in iter
for branch_name in self._repository.listall_branches(self._flag): | for branch_name in self._repository.listall_branches(self._flag):
UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 7-8: invalid continuation byte

is it possible to output in the error the invalid branch name? or have an option to skip the invalid ones?

Dominant language
Python
Stars
1.7k
Forks
408
Avg merge
2d 57m
Merged PRs (30d)
7

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from libgit2/pygit2

All issues in libgit2/pygit2

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.