`Commit.message_trailers` doesn't support multiple occurances

Open
#1,170 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
git, python
Domain
devtools

Research direction

Start at the Commit.message_trailers entry point and inspect its existing tests and documentation. Trace how repeated Signed-off-by trailers are parsed, then verify that every occurrence is exposed through the proposed list-of-tuples representation without losing the existing parsed data.

Written by the indexing model from the issue text.

Description

Some commits may have a number of Signed-off-by tags, but as message_trailers is a dict only the last one is present.

How about also exposing this parsed data, which is very useful, as a list of tuples so that every item can be extracted?

Dominant language
Python
Stars
1.7k
Forks
408
Avg merge
2d 57m
Merged PRs (30d)
7

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from libgit2/pygit2

All issues in libgit2/pygit2

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.